Review Request: Deduplicate code in PatchReview plugin.
Milian Wolff
mail at milianw.de
Fri Apr 1 14:01:34 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100978/#review2295
-----------------------------------------------------------
Ship it!
seems fine with me
- Milian
On March 30, 2011, 9:25 p.m., Andrey Batyiev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100978/
> -----------------------------------------------------------
>
> (Updated March 30, 2011, 9:25 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Move urlForFileModel from PatchReviewToolView to PatchReviewPlugin and remove code duplication.
>
>
> Diffs
> -----
>
> plugins/patchreview/patchreview.h 25aa740
> plugins/patchreview/patchreview.cpp f62609e
>
> Diff: http://git.reviewboard.kde.org/r/100978/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrey
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110401/0904bd7e/attachment.html>
More information about the KDevelop-devel
mailing list