Patch: pluralize removeFile/removeFolder API
Olivier JG
olivier.jg at gmail.com
Tue Oct 12 02:00:50 UTC 2010
On 10/11/2010 05:43 PM, Milian Wolff wrote:
> 2) Cmake might still have a problem with this, afaik it reloads the project as
> soon as a CMakeLists.txt is removed, hence the folders might be invalid
> afterwards. Aleix? Maybe we need to pass one big list of items instead of
> differentiating between files and folders?
I would like to do this, after this patch is in, if everyone is in
agreement.
> 3) the typedefs in ibuildsystemmanager seem to be unused?
I only added one typedef, and moved another one two lines down for
aesthetics. The one I made is used.
> So, I'm all in favor of pushing this. to fix (1) you should make sure you don't
> pass something like this to the manager:<snip>
I believe this was a misunderstanding of my Known Issue #1. I have an
idea as to how to fix it, but I didn't want to put too much in one patch
(for reviewers ease :) ).
-Olivier JG
More information about the KDevelop-devel
mailing list