Review Request: Add man page documentation support to KDevelop

Milian Wolff mail at milianw.de
Sat Nov 27 15:45:52 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100170/#review417
-----------------------------------------------------------

Ship it!


very well done code wise, I'll now apply it locally and test it. If it works, I'll merge your code right away.


documentation/manpage/kdevmanpage.desktop
<http://git.reviewboard.kde.org/r/100170/#comment306>

    don't add translations as a developer, the translators won't be aware of it and have to overwrite it anyways as far as I know. Anyhow, you don't have to change this, just so you know for the future.



documentation/manpage/manpageplugin.h
<http://git.reviewboard.kde.org/r/100170/#comment307>

    can this not be removed?


- Milian


On 2010-11-26 19:27:20, Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100170/
> -----------------------------------------------------------
> 
> (Updated 2010-11-26 19:27:20)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Allow user to load man page documentation directly in the documentation plugin.
> 
> 
> Diffs
> -----
> 
>   documentation/CMakeLists.txt 31ee317 
>   documentation/manpage/CMakeLists.txt PRE-CREATION 
>   documentation/manpage/kdevmanpage.desktop PRE-CREATION 
>   documentation/manpage/manpagedocumentation.h PRE-CREATION 
>   documentation/manpage/manpagedocumentation.cpp PRE-CREATION 
>   documentation/manpage/manpagemodel.h PRE-CREATION 
>   documentation/manpage/manpagemodel.cpp PRE-CREATION 
>   documentation/manpage/manpageplugin.h PRE-CREATION 
>   documentation/manpage/manpageplugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100170/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101127/99184c1a/attachment.html>


More information about the KDevelop-devel mailing list