Review Request: Add replace feature to find in files.

David Nolden david.nolden.kde at art-master.de
Sat Nov 27 13:21:53 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100175/#review415
-----------------------------------------------------------

Ship it!


Looks very good to me

- David


On 2010-11-27 10:19:28, Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100175/
> -----------------------------------------------------------
> 
> (Updated 2010-11-27 10:19:28)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add replace feature to find in files and create new toolview to display results.
> 
> 
> Diffs
> -----
> 
>   interfaces/idocumentcontroller.h d085a62 
>   plugins/grepview/CMakeLists.txt ce5a084 
>   plugins/grepview/grepdialog.h 5fa2cc0 
>   plugins/grepview/grepdialog.cpp e6fee0d 
>   plugins/grepview/grepfindthread.h 27fa8bb 
>   plugins/grepview/grepfindthread.cpp 02deeed 
>   plugins/grepview/grepjob.h 184701a 
>   plugins/grepview/grepjob.cpp faa7fe6 
>   plugins/grepview/grepoutputdelegate.h 45c9c76 
>   plugins/grepview/grepoutputdelegate.cpp ba3236e 
>   plugins/grepview/grepoutputmodel.h ef60a78 
>   plugins/grepview/grepoutputmodel.cpp 73ffbb2 
>   plugins/grepview/grepoutputview.h PRE-CREATION 
>   plugins/grepview/grepoutputview.cpp PRE-CREATION 
>   plugins/grepview/grepoutputview.ui PRE-CREATION 
>   plugins/grepview/grepviewplugin.h 915c15e 
>   plugins/grepview/grepviewplugin.cpp dfad47e 
>   plugins/grepview/grepwidget.ui 768c5ff 
>   plugins/grepview/kdevgrepview.desktop 512230a 
>   plugins/grepview/kdevgrepview.rc d23a181 
>   plugins/grepview/tests/CMakeLists.txt PRE-CREATION 
>   plugins/grepview/tests/findreplacetest.h PRE-CREATION 
>   plugins/grepview/tests/findreplacetest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100175/diff
> 
> 
> Testing
> -------
> 
> We add some test and they work.
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101127/55f05915/attachment.html>


More information about the KDevelop-devel mailing list