Rename Assistant

[Olivier JG]

On 11/23/2010 08:17 PM, Milian Wolff wrote:
> Olivier JG, 23.11.2010:
>> On 11/23/2010 12:03 AM, David Nolden wrote:
>>> 2010/11/22 Olivier JG<olivier.jg at gmail.com>:
>>>> That's bad... unfortunately, maybe I just need my coffee, but I can't
>>>> think of any way to fix this without being able to differentiate
>>>> between automatic changes and the user typing stuff in.
>>>> - Olivier JG
>>> You get notified of all the changes, no? So you could simply stop the
>>> rename assistant as soon as you see an edit somewhere else than the
>>> cursor position.
>>>
>>> Greetings, David
>> @Milian: If this was done at the Code Assistant level, this would
>> obviate the need for that auto-detection you did, wouldn't it? It's
>> happened twice that I've done the "select text including one end of the
>> variable and type over it", and found myself offered a rename with a
>> semicolon at the end because of it.
> Sorry, can't follow you. What auto-detection did I do?
 From and for the record:

commit 35d9c0cad5c2d0113af6d1d3b4690193b28b24d7
Author: Milian Wolff <mail at milianw.de>
Date:   Fri Nov 5 16:54:40 2010 +0100

opt: make sure we don't try to start assistants over and over again
when e.g. setText is called on a document as is done during 'reformat 
source'

CCBUG: 215200