Remove flicker and don't select first view on tab close

Milian Wolff mail at milianw.de
Tue Nov 23 12:26:49 UTC 2010


Milian Wolff, 22.11.2010:
> On Monday 22 November 2010 15:06:11 Milian Wolff wrote:
> > Hey all, esp. David.
> > 
> > Please review and test the patch you find attached and tell me what's
> > wrong with it.
> > 
> > I can so far only report positive things:
> > 
> > - no more flicker when closing tabs as the area is not restored everytime
> > - no funny addViewSilent that might lead to bugs like seen in the
> > container - no custom "activate first view" if we didn't find the old
> > active view, as that is simply wrong. When you close a tab, the one next
> > to it should be activated.
> > 
> > I hope I can introduce this to fix the last regressions introduced by
> > 4b114d9c734ef1bd3e156cfc114b7e87ec8adb8e or
> > f871ff0b5445b1e710dac4107d9a1e0c3c486e8a
> 
> of course I forgot the patch, here it is...

Btw: I send this from the wrong mail adress hence it was in moderation queue . 
I notice that you already committed

0cb0d8d3721f3fff524dbca6873e10e95eafe6e2

but imo my patch is much nicer.

What do you say?
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101123/cce58717/attachment-0001.sig>


More information about the KDevelop-devel mailing list