[KDevelop] 7e5dd1f: Revert "make CPP unit tests work again"

[David Nolden]

This is obviously ugly as hell, and essentially means that every such
function can lead to random multi-threading related crashes. A proper fix is
needed, but as i'm not on my computer right now, that's all I can add.

Am 27.05.2010 21:22 schrieb "Milian Wolff" <mail at milianw.de>:

Andreas Pakulat, 27.05.2010:

> On 27.05.10 14:03:04, Milian Wolff wrote:
> > commit 7e5dd1fd0f0d50b4a3ca235cb791c4eb465be599
> > ...
I'm all for keeping it. Really, it's much cleaner and nicer to work with.

I've found a way to "fix" my first attempt at the fix. It breaks due to
multithreading which I didn't notice before since I only ran kdevelop with
projects that had proper duchain already setup and hence didn't trigger this
case that only occurred during heavy reparsing.

My "fix" is calling one of the new getters earlier so that it is already
initialized before two threads try to call it.

But I think this is kind of ugly... is this a "proper" fix? Do I need to do
this for _every_ such getter?


> Apologies for not running the unit-tests before merging the branch, I
> didn't think they'd break...
Bad Andreas :P

Bye
--

Milian Wolff
mail at milianw.de
http://milianw.de

--
KDevelop-devel mailing list
KDevelop-devel at kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100527/deea84b9/attachment.html>