What to do with the kdebase/workspace dependency?

[Andreas Pakulat]

On 12.05.10 21:22:57, Alexander Neundorf wrote:
> On Tuesday 11 May 2010, Andreas Pakulat wrote:
> > On 11.05.10 23:06:31, Alexander Neundorf wrote:
> > > On Tuesday 11 May 2010, Andreas Pakulat wrote:
> > > > On 11.05.10 22:18:01, Alexander Neundorf wrote:
> > > > > On Tuesday 11 May 2010, Andreas Pakulat wrote:
> > > > > > Hi,
> > > > > >
> > > > > > so, 4.0 is out and I think we should try to tackle the
> > > > > > kdebase/workspace dependency. Its a problem for various distro's
> > > > > > which split the libraries, its a problem for people compiling
> > > > > > kdebase themselves and disabling parts of it (because the
> > > > > > kdebase/workspace cmake stuff doesn't support this properly)
> > > > >
> > > > > What exactly ?
> > > >
> > > > There's just a single KDE4WorkspaceConfig.cmake that loads and creates
> > > > all targets and only those that were active during building of
> > > > kdebase/workspace. What would be needed is a way to do find_package(
> > > > KDE4Workspace 4.3.0 COMPONENTS processui processcore REQUIRED) and have
> > > > it fail if either processui or processcore libraries are missing.
> > >
> > > Would checking if(KDE4WORKSPACE_PROCESSUIL
> > >
> > > Right now this is in KDE4WorkspaceConfig.cmake:
> > > _kde4workspace_set_lib_vars( PROCESSUI          processui)
> > >
> > > Would
> > > if(TARGET processui)
> > >    _kde4workspace_set_lib_vars( PROCESSUI          processui)
> > > endif(TARGET processui)
> > >
> > >
> > > be better ?
> > > Then you could check
> > > if (KDE4WORKSPACE_PROCESSUIL_LIBRARY)
> > >  ...
> > > endif(KDE4WORKSPACE_PROCESSUIL_LIBRARY)
> >
> > I'm not following, the thing that came up on IRC today was somebody who
> > had kdebase/workspace built+installed, but not libs/ksysguard (i.e.
> > processui/processcore where missing). 
> 
> Did he build that himself ?
> After a quick look I didn't see a way how to disable ksysguard from building 
> and installing.

Yeap, self-compiled afaik. No idea how he did that.
 
> When kdebase/workspace is installed, it installs a Config.cmake file, which 
> contains information about the installed package.
> This file assumes that processcore is always there, so it adds this imported 
> target.

Yeap, I didn't check the workspace-cmake files before, so this is ok. If
people hack in there to disable parts, then its their fault if other
things break.

Andreas

-- 
You have literary talent that you should take pains to develop.