Review Request: Allow adding watches with spaces and double quotes.

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3935/#review5516
-----------------------------------------------------------

Ship it!


Patch looks good.

For the unit test I'd prefer a new one, that tests exactly this issue.

Can you commit yourself?

- Niko


On 2010-05-08 11:22:14, Valentyn Pavliuchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3935/
> -----------------------------------------------------------
> 
> (Updated 2010-05-08 11:22:14)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Allows adding watches with spaces and double quotes.
> This patch ensures that watch expressions are passed to gdb being enquoted and adds escapes for quotes inside expressions.
> Also updated unit tests to test it.
> 
> 
> This addresses bug 235759.
>     https://bugs.kde.org/show_bug.cgi?id=235759
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevelop/debuggers/gdb/gdbvariable.h 1121501 
>   /trunk/extragear/sdk/kdevelop/debuggers/gdb/gdbvariable.cpp 1121501 
>   /trunk/extragear/sdk/kdevelop/debuggers/gdb/unittests/gdbtest.cpp 1121501 
> 
> Diff: http://reviewboard.kde.org/r/3935/diff
> 
> 
> Testing
> -------
> 
> Unit test passed.
> Checked manually for both spaces and double quotes - both work.
> 
> 
> Thanks,
> 
> Valentyn
> 
>