Review Request: Use unordered_map when gxx >= 4.3 to fix a bunch of warnings.

[Milian Wolff]

> On 2010-05-04 21:54:10, Andreas Pakulat wrote:
> > Hmm, I'd rather drop older compiler support than adding a bunch of ifdef's and cmake-checks, but gcc 4.2 is "only" 2 years old, which means all LTS distributions will still have it (or even gcc 4.1). So fine with me for now (but we should re-evaluate this in a year).

closing as committed


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3889/#review5419
-----------------------------------------------------------


On 2010-05-04 20:20:53, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3889/
> -----------------------------------------------------------
> 
> (Updated 2010-05-04 20:20:53)
> 
> 
> Review request for KDevelop, Milian Wolff and David Nolden.
> 
> 
> Summary
> -------
> 
> Fix a bunch of compile warnings for gnu c++ >= 4.3. I chose for the patch which is as less intrusive as possible. Ideally we just replace the whole hash_map with QHash. However, I don't have time to profile the difference. David, any reason why you didn't use QHash in in particular?
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/sdk/kdevelop/languages/cpp/CMakeLists.txt 1122832 
>   trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.h 1122832 
> 
> Diff: http://reviewboard.kde.org/r/3889/diff
> 
> 
> Testing
> -------
> 
> Compiled with both cases for GCC_IS_NEWER_THAN_4_3, works for me and with unordered_map I don't get the warnings anymore.
> 
> 
> Thanks,
> 
> Bertjan
> 
>