Review Request: Show definition as default action in classbrowser

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3564/#review5425
-----------------------------------------------------------


There is some unsafe stuff happening in this patch that should be fixed:
You can not hold a "Declaration*" and then release the duchain read-lock. Instead, at least DeclarationPointer should be used, and it has to be checked for being zero after the read-lock has been re-acquired.

- David


On 2010-04-12 17:14:08, André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3564/
> -----------------------------------------------------------
> 
> (Updated 2010-04-12 17:14:08)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch is a fix/addition for Bug 223124 that I filed myself. Instead of jumping to a function's declaration when selecting an item in class browser, the function's definition is shown. I think this is much more intuitive behavior and is also implemented in most other IDEs.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.h 1114037 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp 1114037 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classtree.cpp 1114037 
> 
> Diff: http://reviewboard.kde.org/r/3564/diff
> 
> 
> Testing
> -------
> 
> Tested with three different projects without problems/crashs/deadlocks.
> 
> 
> Thanks,
> 
> André
> 
>