Review Request: render_position.cpp:94: warning: comparison between signed and unsigned integer expressions

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1864/#review5415
-----------------------------------------------------------


this is assigned to the wrong group, please fix it

- Milian


On 2009-10-16 17:44:25, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1864/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 17:44:25)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> khtml/rendering/render_position.cpp:94: warning: comparison between signed and unsigned integer expressions
> khtml/rendering/render_position.cpp:98: warning: comparison between signed and unsigned integer expressions
> 
> at
> InlineBox* RenderPosition::getInlineBoxAndOffset(int& offset) const
> 
> I propose to change the declaration of "renderOffset" to
> "unsigned int"
> see: render_position-gm-13.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/khtml/rendering/render_position.cpp 1033934 
> 
> Diff: http://reviewboard.kde.org/r/1864/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>