Review Request: Display of many function overloads in code completion
Thomas Schöps
tom.schoeps at googlemail.com
Tue May 4 21:07:52 UTC 2010
> On 2010-05-04 20:57:08, Milian Wolff wrote:
> > committed with my changes works fine imo - closing now.
If I use Ctrl+Space, I usually want to get all information which is not possible like this, so I disagree ... but you decide ;-)
Ideally, clicking on "more items" should also show more items, like the array display of the debugger.
Imo increasing the number of overloads shown from 5 to e.g. 8 would be a good idea. But it's still better than the behavior before.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3612/#review5405
-----------------------------------------------------------
On 2010-04-15 14:29:12, Thomas Schöps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3612/
> -----------------------------------------------------------
>
> (Updated 2010-04-15 14:29:12)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> I tried to fix this:
> https://bugs.kde.org/show_bug.cgi?id=215206
>
> With the patch, Ctrl+Space always shows all overloads, while automatic invocation of code completion shows the first 5 overloads and possibly "x more overloads of y".
> Currently, the automatic invocation case doesn't happen because automatic code completion after '(' is disabled.
> It would be even better if the "more overloads" item would be clickable to reveal the remaining items, but I don't know how to implement this and as it isn't shown currently, it's probably not too important.
>
> I've never coded on KDevelop/KDevplatform or even a KDE app before, so please check the patch carefully and tell me if that is not the correct way to implement it ;-)
>
>
> Diffs
> -----
>
> trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.h 1115078
> trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.cpp 1115078
> trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletioncontext.h 1115078
> trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionmodel.cpp 1115078
> trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionworker.h 1115078
> trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionworker.cpp 1115078
>
> Diff: http://reviewboard.kde.org/r/3612/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas
>
>
More information about the KDevelop-devel
mailing list