Review Request: Add support for parsing Q_PROPERTY declarations

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3814/#review5384
-----------------------------------------------------------


ok so far except for a few small things, but please wait for david to review as well.


/trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp
<http://reviewboard.kde.org/r/3814/#comment5095>

    I'm not sure about this chained call without any conditional checking on validity. david should comment on it probably.
    



/trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp
<http://reviewboard.kde.org/r/3814/#comment5096>

    this should be done once at the end of the class and not for each declaration inside a class declaration.
    
    note that it would e.g. be called for every local var declaration inside an inline method.



/trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/qpropertydeclaration.h
<http://reviewboard.kde.org/r/3814/#comment5098>

    unsure whether this should be inlined, david?
    
    and you can also use init lists for this if you'd really care for speed ;-)



/trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/qpropertydeclaration.h
<http://reviewboard.kde.org/r/3814/#comment5097>

    these should use bit flags or how it's called, i.e.:
    
    bool m_isDesignable : 1;
    bool m_isScriptable : 1;
    ...



/trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/qpropertydeclaration.h
<http://reviewboard.kde.org/r/3814/#comment5099>

    no api dox whatsoever, please add some



/trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.cpp
<http://reviewboard.kde.org/r/3814/#comment5100>

    brace on newline



/trunk/extragear/sdk/kdevelop/languages/cpp/parser/tests/test_parser.cpp
<http://reviewboard.kde.org/r/3814/#comment5101>

    please extend for the other qproperty features you add support for in this patch


- Milian


On 2010-04-26 10:10:16, Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3814/
> -----------------------------------------------------------
> 
> (Updated 2010-04-26 10:10:16)
> 
> 
> Review request for KDevelop and David Nolden.
> 
> 
> Summary
> -------
> 
> Add support for parsing Q_PROPERTY declarations to the c++ parser
> 
> Please review for later inclusion into 4.0.0 release.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/CMakeLists.txt 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/declarationbuilder.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/qpropertydeclaration.h PRE-CREATION 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/qpropertydeclaration.cpp PRE-CREATION 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/ast.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/default_visitor.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/default_visitor.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/dumptree.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/lexer.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tests/test_parser.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/visitor.h 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/visitor.cpp 1117141 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/setuphelpers.cpp 1117141 
> 
> Diff: http://reviewboard.kde.org/r/3814/diff
> 
> 
> Testing
> -------
> 
> run unit tests
> 
> 
> Thanks,
> 
> Tobias
> 
>