controlflowgraph plugin moved to kdereview ...

[Milian Wolff]

On Saturday 19 June 2010 13:39:30 Sandro Andrade wrote:
> Hi Niko,
> 
> Thanks for reporting this, I actually removed some unnecessary DUChain
> locks some weeks ago, may be I am
> misunderstanding this.
> 
> The function in which the assert hapenned
> (DUChainControlFlow::processFunctionCall) is only called from other
> functions which already holds a DUChain lock. I am considering the
> locks are kept in ordinary function invocations
> and when using signals/slots.
> 
> I mean:
> 
> X::m1()
> {
> DUChainReadLocker lock(DUChain::lock());
> DUChainControlFlow::processFunctionCall();
> }
> 
> or
> 
> X::m2()
> {
> DUChainReadLocker lock(DUChain::lock());
> emit signalConnectedToProcessFunctionCall();
> }
> 
> Since connections aren't queued wouldn't the locks be kept in this both
> cases ?

You shouldn't hold across signals.
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100619/d3347a66/attachment.sig>