DocumentChange unpractical for signature assistant

Milian Wolff mail at milianw.de
Tue Jul 6 12:00:35 UTC 2010


Milian Wolff, 06.07.2010:
> David Nolden, 06.07.2010:
> > You anyway need the exact range that you want to replace, so I don't see
> > the problem specific to DocumentChange. You can simply read the old text
> > from the range out of the editor. That somewhat defeats the purpose
> > 'safety', as it might happen that you replace _anything_. Your idea with
> > the AST would be the best, but might be some work. It's the only way to
> > reliably get the whole range that needs to be replaced.
> 
> Indeed, my mail title was wrong with making DocumentChange responsible for
> it. I will of course still use it, just the idea on how to find the range
> is currently a bit wrong.
> 
> I've now started with the regexp thingy and createCodeRepresentation, which
> I remembered just now. If that works well enough, I'll keep it, otherwise
> I'll use the AST after all.

committed, seems to work well enough in my tests.

If you guys find anything, tell me and I'll try to fix it.

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100706/b93f7959/attachment.sig>


More information about the KDevelop-devel mailing list