OutputView Model

[Andreas Pakulat]

On 30.01.10 23:27:05, Niko Sams wrote:
> On Sat, Jan 30, 2010 at 22:25, Andreas Pakulat <apaku at gmx.de> wrote:
> > On 30.01.10 21:59:34, Niko Sams wrote:
> >> Hi,
> >>
> >> I'm trying to fix that crash:
> >> https://bugs.kde.org/show_bug.cgi?id=222317
> >> By setting OutputJob::m_outputModel to 0 when the model gets deleted.
> >>
> >> And I found out that the OutputModel is only deleted on kdevelop quit.
> >
> > Apparently OutputData doesn't have a destructor that deletes the model
> > and delegate if it own either or both.
> >
> >> Same with ToolViewData
> >
> > Uhm, unless I'm mistaken toolview data is deleted when a toolview is
> > removed (see StandardOutputView::removeToolView). Of course if you don't
> > close the toolview explicitly that'll only happen on shutdown (or maybe
> > the standardoutputview::cleanup function doesn't remove all toolviews?
> The destructors of OutputModel, OutputData and ToolViewData are never called
> except on shutdown.

I agree about outputmodel and outputdata, but toolviewdata is clearly
deleted in removeToolView. You might want to check wether that function
is not called for some reason when removing a toolview.

Feel free to add the missing delete's for outputdata, the model and the
delegate as I said.

Andreas

-- 
That secret you've been guarding, isn't.