Review Request: Vcs: Move repair of borked svn diffs from VCSCommitDiffPatchSource to SvnDiffJob

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2637/#review3733
-----------------------------------------------------------

Ship it!


The patch is totally fine, but I see you already comitted it. While there's no strict policy on that, I think it would be nice to wait until two people looked at the patch in the future ;)

- Andreas


On 2010-01-17 12:42:21, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2637/
> -----------------------------------------------------------
> 
> (Updated 2010-01-17 12:42:21)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Fixing a borked diff of one module in a common code path doesn't seems like a sensible idea.
> I moved the code to the plugin in question.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevplatform/plugins/subversion/svndiffjob.cpp 1075986 
>   /trunk/extragear/sdk/kdevplatform/vcs/vcsdiffpatchsources.h 1075986 
>   /trunk/extragear/sdk/kdevplatform/vcs/vcsdiffpatchsources.cpp 1075986 
>   /trunk/extragear/sdk/kdevplatform/vcs/vcspluginhelper.cpp 1075986 
>   /trunk/extragear/sdk/kdevplatform/vcs/widgets/vcscommitdialog.cpp 1075986 
> 
> Diff: http://reviewboard.kde.org/r/2637/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>