Review Request: Vcs: Move repair of borked svn diffs from VCSCommitDiffPatchSource to SvnDiffJob

Fabian Wiesel fabian.wiesel at googlemail.com
Sun Jan 17 12:42:22 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2637/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

Fixing a borked diff of one module in a common code path doesn't seems like a sensible idea.
I moved the code to the plugin in question.


Diffs
-----

  /trunk/extragear/sdk/kdevplatform/plugins/subversion/svndiffjob.cpp 1075986 
  /trunk/extragear/sdk/kdevplatform/vcs/vcsdiffpatchsources.h 1075986 
  /trunk/extragear/sdk/kdevplatform/vcs/vcsdiffpatchsources.cpp 1075986 
  /trunk/extragear/sdk/kdevplatform/vcs/vcspluginhelper.cpp 1075986 
  /trunk/extragear/sdk/kdevplatform/vcs/widgets/vcscommitdialog.cpp 1075986 

Diff: http://reviewboard.kde.org/r/2637/diff


Testing
-------


Thanks,

Fabian





More information about the KDevelop-devel mailing list