Review Request: VcsStatusInfo: Remove *Index enums from VcsStatusInfo

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2571/#review3681
-----------------------------------------------------------

Ship it!


+10, code removal is always good and indeed having public API thats specific to one plugin is complete nonsense. The fact that git doesn't build anymore is not a problem as its unmaintained anyway.

- Andreas


On 2010-01-13 13:18:21, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2571/
> -----------------------------------------------------------
> 
> (Updated 2010-01-13 13:18:21)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The *Index-States are not DVCS, but Git-specific.
> Removing it and the specialised code in VcsCommitDialog allows the (now hopefully fixed) mercurial-plugin to work correctly again.
> The git-plugin, however, won't even complile anymore.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevplatform/vcs/vcsstatusinfo.h 1073011 
>   /trunk/extragear/sdk/kdevplatform/vcs/widgets/vcscommitdialog.cpp 1073011 
> 
> Diff: http://reviewboard.kde.org/r/2571/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>