Review Request: Fixes missing "<sometext>" in cmake help
Milian Wolff
mail at milianw.de
Tue Feb 23 20:09:01 UTC 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3040/#review4257
-----------------------------------------------------------
Ship it!
use Qt::escape() but other than that looks fine to me, please commit
trunk/extragear/sdk/kdevelop/projectmanagers/cmake/cmakedocumentation.cpp
<http://reviewboard.kde.org/r/3040/#comment3778>
Please use Qt::escape() for that purpose
http://doc.trolltech.com/4.6/qt.html#escape
- Milian
On 2010-02-23 02:22:51, Roman Byshko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3040/
> -----------------------------------------------------------
>
> (Updated 2010-02-23 02:22:51)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> This patch fixes issue with '<', '>' symbols in cmake help. They are replaced with < and > correspondingly.
>
>
> Diffs
> -----
>
> trunk/extragear/sdk/kdevelop/projectmanagers/cmake/cmakedocumentation.cpp 1094581
>
> Diff: http://reviewboard.kde.org/r/3040/diff
>
>
> Testing
> -------
>
> Basic testing done. Now one can see missed parts of help. For example see SET command.
>
>
> Thanks,
>
> Roman
>
>
More information about the KDevelop-devel
mailing list