Review Request: Convert QPointer in QWeakPointer (Bug 260586)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100252/#review661
-----------------------------------------------------------


nearly done now :)


languages/cpp/codegen/unresolvedincludeassistant.cpp
<http://git.reviewboard.kde.org/r/100252/#comment480>

    you misunderstood me here. do it this way:
    
    KDialog dialog(KDevelop::ICore::self()->...);
    
    and change dialog-> to dialog.
    
    otherwise you would leak it now.


- Milian


On 2010-12-29 17:44:58, Nathanaël Restori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100252/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 17:44:58)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The patch convert every QPointer in QWeakPointer
> In the bug report, Millan Wolff says : "it shows that in GDB the pointer was used quite a lot without being checked,
> you should do that at the start of each function, or at least Q_ASSERT on it." but for hardly every function, there is a "Q_ASSERT(thePointer)", a "if (thePointer)" or a "if (!thePointer)"
> 
> 
> This addresses bug 260586.
>     http://bugs.kde.org/show_bug.cgi?id=260586
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debuggerplugin.h 9144d25 
>   debuggers/gdb/debugsession.h 4abbc11 
>   debuggers/gdb/debugsession.cpp b050db2 
>   debuggers/gdb/gdbcommand.h 63c4c34 
>   debuggers/gdb/gdbcommand.cpp c46f0ec 
>   debuggers/gdb/gdbvariable.cpp 8e47f6e 
>   debuggers/gdb/unittests/gdbtest.cpp 41980e9 
>   languages/cpp/codecompletion/model.h 84c1e1e 
>   languages/cpp/codegen/codeassistant.h a5cbeb8 
>   languages/cpp/codegen/codeassistant.cpp c9a3673 
>   languages/cpp/codegen/unresolvedincludeassistant.cpp 9c5872b 
> 
> Diff: http://git.reviewboard.kde.org/r/100252/diff
> 
> 
> Testing
> -------
> 
> Only try to compile.
> 
> 
> Thanks,
> 
> Nathanaël
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101229/e510cf8a/attachment.html>