Review Request: cmakeduchaintest + fixes

[Floris Ruijter]

> On 2010-12-29 02:31:34, Aleix Pol Gonzalez wrote:
> > If it makes the tests to pass, +1
> > Please, use QSet.
> > 
> > Thank you! :)
> 
> Aleix Pol Gonzalez wrote:
>     Oh also please note that there are c++ changes here.

the c++-change is a minor fix and a comment saying there's a bug specifically: it creates a map of token-> token-name mappings which already exists in token.[ch]pp and therefore that table should be used. i couldn't use QSet because the current implementation of the ranges has the hash function in the global namespace making adl fail. PovAddict was suposed to fix that (perhaps he has i don't know), but in the meantime this should work.


- Floris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100258/#review648
-----------------------------------------------------------


On 2010-12-28 17:13:38, Floris Ruijter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100258/
> -----------------------------------------------------------
> 
> (Updated 2010-12-28 17:13:38)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> 1) should fixes a few possible bugs.
> 2) makes the cmakeduchaintest pass
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/expressionvisitor.cpp 099b76e 
>   languages/cpp/parser/codegenerator.cpp fcdb04c 
>   languages/cpp/parser/tests/test_generator.cpp 1fd02b5 
>   projectmanagers/cmake/tests/cmakeduchaintest.cpp d37682b 
> 
> Diff: http://git.reviewboard.kde.org/r/100258/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Floris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101229/d4414e74/attachment.html>