Review Request:
Nathanaël Restori
nathidem at hotmail.com
Mon Dec 27 17:27:40 UTC 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100252/
-----------------------------------------------------------
Review request for KDevelop.
Summary
-------
The patch convert every QPointer in QWeakPointer
In the bug report, Millan Wolff says : "it shows that in GDB the pointer was used quite a lot without being checked,
you should do that at the start of each function, or at least Q_ASSERT on it." but for hardly every function, there is a "Q_ASSERT(thePointer)", a "if (thePointer)" or a "if (!thePointer)"
This addresses bug 260586.
http://bugs.kde.org/show_bug.cgi?id=260586
Diffs
-----
debuggers/gdb/debuggerplugin.h 9144d25
debuggers/gdb/debugsession.h 4abbc11
debuggers/gdb/debugsession.cpp b050db2
debuggers/gdb/gdbcommand.h 63c4c34
debuggers/gdb/gdbcommand.cpp c46f0ec
languages/cpp/codecompletion/model.h 84c1e1e
languages/cpp/codegen/codeassistant.h a5cbeb8
languages/cpp/codegen/codeassistant.cpp c9a3673
Diff: http://git.reviewboard.kde.org/r/100252/diff
Testing
-------
Only try to compile.
Thanks,
Nathanaël
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101227/c4d62a5e/attachment.html>
More information about the KDevelop-devel
mailing list