Review Request: Do not mess with other active working sets when calling for a review.

[Dmitry Risenberg]

> On 2010-12-26 16:47:38, Aleix Pol Gonzalez wrote:
> > I think the idea here is to create a new Working Set for the reviewing (and close if there was any in the first place). I'm fine with that patch.

I agree, and this was my original intention, but having investigated the current Working Set implementation, I found out that they are just something like passive configs that have no their own actions and have to be manipulated from outside, for example the owning Area - here come the manipulations with views. Giving Working Sets their own behaviour would mean changing the ownership model between the related classes - Views and Areas, which might be the right thing, but I didn't want to do it with a not-well-known code lacking unit tests. I can try working on that if it would be of any future value, otherwise it seems too complicated to mess with.


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100243/#review616
-----------------------------------------------------------


On 2010-12-25 11:14:13, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100243/
> -----------------------------------------------------------
> 
> (Updated 2010-12-25 11:14:13)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When opening a review
> 
> 1) Show documents even if they were in "review" working set before.
> 2) Close only views in current area, not documents themselves - this avoids messing with other active working sets.
> 
> 
> This addresses bug 260663.
>     http://bugs.kde.org/show_bug.cgi?id=260663
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/patchreview.cpp 4b4b3939008f0d2d70535fe5beb74c24056786c4 
> 
> Diff: http://git.reviewboard.kde.org/r/100243/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101226/d74ac813/attachment.html>