Review Request: pointer-to-member ast and parsing implementation

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100239/#review613
-----------------------------------------------------------


still missing unit tests, and some small issues. once they are resolved (and unit tests are added) it can be merged.


languages/cpp/cppduchain/ptrtomembertype.h
<http://git.reviewboard.kde.org/r/100239/#comment450>

    this is missing the Cpp namespace



languages/cpp/cppduchain/ptrtomembertype.cpp
<http://git.reviewboard.kde.org/r/100239/#comment451>

    you are "using namespace KDevelop", no need for that here hence



languages/cpp/cppduchain/ptrtomembertype.cpp
<http://git.reviewboard.kde.org/r/100239/#comment452>

    style nazi: `if (this == _rhs)` like you use in the other conditionals please



languages/cpp/cppduchain/type_visitor.cpp
<http://git.reviewboard.kde.org/r/100239/#comment453>

    style nazi: PtrToMemberAst* ast = ptrOp->mem_ptr;
    
    generally, whitespaces around operators, same a few lines below


- Milian


On 2010-12-24 18:12:12, Floris Ruijter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100239/
> -----------------------------------------------------------
> 
> (Updated 2010-12-24 18:12:12)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> the summary covers it quite well.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/CMakeLists.txt 7eba67f 
>   languages/cpp/cppduchain/cpptypes.h 87645e9 
>   languages/cpp/cppduchain/expressionvisitor.cpp 099b76e 
>   languages/cpp/cppduchain/ptrtomembertype.h PRE-CREATION 
>   languages/cpp/cppduchain/ptrtomembertype.cpp PRE-CREATION 
>   languages/cpp/cppduchain/type_visitor.cpp cf00e6c 
>   languages/cpp/cppduchain/typebuilder.h 7fff507 
>   languages/cpp/cppduchain/typebuilder.cpp 73723b2 
>   languages/cpp/cppduchain/usebuilder.cpp 68b08fb 
>   languages/cpp/parser/ast.h cd896f7 
>   languages/cpp/parser/default_visitor.cpp 3d061ff 
>   languages/cpp/parser/parser.cpp b07910a 
> 
> Diff: http://git.reviewboard.kde.org/r/100239/diff
> 
> 
> Testing
> -------
> 
> as far as i tested, parsing works flawlessly
> 
> 
> Thanks,
> 
> Floris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101226/c39c4dee/attachment.html>