Review Request: Check for possible unloading of version control plugin in ProjectPrivate.

[Milian Wolff]

On Tuesday 21 December 2010 14:06:39 Aleix Pol Gonzalez wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100225/#review592
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Looks good to me.
> Can we remove the hasError method now?

I've investigated it today and no, it's not possible. 

Or well, it would be possible if we only return QWeakPointers everywhere from 
the PluginController. 

pluginManager->allPluginsForExtension( "org.kdevelop.IBasicVersionControl" )

That call in project.cpp:386 can lead to crashes if we unload the git plugin 
via some Qt::QueuedConnection, even if I temporarily use a list of 
QWeakPointers in allPluginsForExtension and convert it afterwards.

Anyhow, I don't find that API too bad, it's quite easy to use and works well. 
So should we live with it?

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101224/26ba4a30/attachment.sig>