Review Request: pointer-to-member ast and parsing implementation

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100239/#review610
-----------------------------------------------------------


looks good but is missing unit tests, please add a few to make sure this works as intended and that we are safe against regressions in the future.

also see my review to the kdevplatform part, merge both into a single patch for kdevelop and fix it all, than I'm happy to merge this. Really good work, thank you!

- Milian


On 2010-12-23 23:06:44, Floris Ruijter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100239/
> -----------------------------------------------------------
> 
> (Updated 2010-12-23 23:06:44)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> the summary covers it quite well.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/expressionvisitor.cpp 099b76e 
>   languages/cpp/cppduchain/type_visitor.cpp cf00e6c 
>   languages/cpp/cppduchain/typebuilder.h 7fff507 
>   languages/cpp/cppduchain/typebuilder.cpp 73723b2 
>   languages/cpp/cppduchain/usebuilder.cpp 68b08fb 
>   languages/cpp/parser/ast.h cd896f7 
>   languages/cpp/parser/default_visitor.cpp 3d061ff 
>   languages/cpp/parser/parser.cpp b07910a 
> 
> Diff: http://git.reviewboard.kde.org/r/100239/diff
> 
> 
> Testing
> -------
> 
> as far as i tested, parsing works flawlessly
> 
> 
> Thanks,
> 
> Floris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101224/49e5e621/attachment.html>