Review Request: ptrtomembertype implementation

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100241/#review609
-----------------------------------------------------------


I don't quite understand what you mean in the "testing" paragraph - is KDevelop now having troubles with the "." to "->" conversion? That code is in cpp/codecompletin/context.cpp:629 and :672.

Generally I think this should all be moved to KDevelop as I don't know any other language that would need it. We can still move it to kdevplatform if need arises.


language/duchain/types/alltypes.h
<http://git.reviewboard.kde.org/r/100241/#comment443>

    is this useful for other languages than cpp? if not, please move it to kdevelop/languages/cpp



language/duchain/types/ptrtomembertype.h
<http://git.reviewboard.kde.org/r/100241/#comment445>

    please don't indent in namespaces



language/duchain/types/ptrtomembertype.h
<http://git.reviewboard.kde.org/r/100241/#comment446>

    seems to be fine, but can be checked/fixed later. our current mechanism sucks quite bad but maybe we have some docs lying around somewhere...



language/duchain/types/ptrtomembertype.cpp
<http://git.reviewboard.kde.org/r/100241/#comment444>

    please use kDebug for debug output



language/duchain/types/ptrtomembertype.cpp
<http://git.reviewboard.kde.org/r/100241/#comment447>

    arg(a1, a2, ...) is faster, use that please



language/duchain/types/ptrtomembertype.cpp
<http://git.reviewboard.kde.org/r/100241/#comment448>

    david will have to comment, but to me it looks OK. afaik it's not that important anyways



language/duchain/types/typesystem.cpp
<http://git.reviewboard.kde.org/r/100241/#comment449>

    style nazi: would be cool if you could use the syntax as above for all new init lists:
    
    MyClass::MyClass(args)
      : member(asdf), member2(asdf)
      , member3(asdf), ...
    
    :) thanks


- Milian


On 2010-12-23 23:05:08, Floris Ruijter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100241/
> -----------------------------------------------------------
> 
> (Updated 2010-12-23 23:05:08)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> implementing the PtrToMemberType, type which represents pointer-to-member types ;) like int foo::* bar;
> 
> 
> Diffs
> -----
> 
>   language/CMakeLists.txt 67985db 
>   language/duchain/types/alltypes.h e233985 
>   language/duchain/types/pointertype.h deb40ed 
>   language/duchain/types/ptrtomembertype.h PRE-CREATION 
>   language/duchain/types/ptrtomembertype.cpp PRE-CREATION 
>   language/duchain/types/typesystem.cpp 941e541 
>   language/duchain/types/typesystemdata.h 5bf470c 
> 
> Diff: http://git.reviewboard.kde.org/r/100241/diff
> 
> 
> Testing
> -------
> 
> i did some personal testing, since i marked a pointer type, kdevelop will change a dot after an instance of this type to an arrow eventhough any of the two is a syntactic error in itself. i didnt't check how .* is implemented... it also fixes a bug in which you have a type like int foo::* but kdevelop thinks its just int. ie kdevelop ignored the whole pointer to member thing, not anymore :)
> 
> 
> Thanks,
> 
> Floris
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101224/9bf3c646/attachment.html>