Review Request: [Bugfix 259908] Update container's current widget on creating a split view

Andreas Pakulat apaku at gmx.de
Sun Dec 19 00:43:16 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100219/#review570
-----------------------------------------------------------

Ship it!


No real need for the explicit this-> qualification, but looks fine otherwise. Please commit

- Andreas


On 2010-12-18 19:46:18, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100219/
> -----------------------------------------------------------
> 
> (Updated 2010-12-18 19:46:18)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Container's widget is updated if necessary when a new widget is added to it. This fixes https://bugs.kde.org/show_bug.cgi?id=259908, where labels are not shown in split views when tab bar is disabled.
> 
> This is a debugging-based patch, so there may be a better way to fix this bug.
> 
> 
> Diffs
> -----
> 
>   sublime/container.cpp 6b6a64bf54d20a90b84c4a3f00403ddd774dcf78 
> 
> Diff: http://git.reviewboard.kde.org/r/100219/diff
> 
> 
> Testing
> -------
> 
> Tested with multiple split views with tabs both on and off.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101219/09e84240/attachment.html>


More information about the KDevelop-devel mailing list