[KDevPlatform/1.2] 5774a52: Check that git is installed when loading Git Suppo

[Milian Wolff]

On Saturday 18 December 2010 13:51:45 Aleix Pol wrote:
> On Fri, Dec 17, 2010 at 10:47 PM, Dmitry Risenberg <
> 
> dmitry.risenberg at gmail.com> wrote:
> > commit 5774a52c3a31a5deac524e36df7af1a20b0671c3
> > branch 1.2
> > Author: Dmitry Risenberg <dmitry.risenberg at gmail.com>
> > Date:   Sat Dec 18 00:03:12 2010 +0300
> > 
> >    Check that git is installed when loading Git Support plugin.
> >    CCBUG: 257650.

...

> This patch looks really ugly.
> 
> Wouldn't it be easier that if it's not found Git support unloaded himself
> automatically from the PluginController when constructed?

Interesting idea, I didn't came up with that. Dmitry, could you try to call

virtual bool unloadPlugin( const QString & plugin ) = 0;

from a delayed slot, i.e. in the ctor of the plugin do:

if (!gitInstalled) {
  QMetaObject::invokeMethod(this, "unloadDelayed");
  return;
}

then:

private slots:
  void unloadDelayed() {
    KDevelop::ICore::self()->pluginController()->unloadPlugin("git");
    // or whatever the name is here...
  }

bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101218/8429f57e/attachment.sig>