Review Request: Disable git plugin if git is not installed in the system.

Milian Wolff mail at milianw.de
Fri Dec 17 21:30:12 UTC 2010 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100216/#review567
-----------------------------------------------------------


please cleanup the patch to only include your actual changes

- Milian


On 2010-12-17 21:23:34, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100216/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 21:23:34)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=257650
> 
> 
> This addresses bug 257650.
>     http://bugs.kde.org/show_bug.cgi?id=257650
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 103788766feb77ed17271835d63eca7924a7231c 
>   debugger/CMakeLists.txt 639fc995e2b5b3208a35762670debb48587480a2 
>   documentation/CMakeLists.txt 7b0c44c5ac60a2ef9fc8ca7b0fd1f632ecc0adb3 
>   interfaces/CMakeLists.txt 4fd1ec4d6649c51ec65f54ccc72f027ba314e453 
>   interfaces/contextmenuextension.h 5e3ba844f4762179cbfdbea6e1b24128afb78839 
>   interfaces/foregroundlock.cpp ada7db9285de9090b7f09e6eb7d5d89cfa1e963b 
>   interfaces/iassistant.h 8b0d6d571197ea6dd487557087827af20a9b37c7 
>   interfaces/idebugcontroller.h 56b4c7ce9ffbc122d69a8efc0e64956d73ca936e 
>   interfaces/ilanguage.h d88b17dcec0ac0b082a9f4aa18caae2407866f3e 
>   interfaces/ilaunchmode.h 2253ae027f5eebdce20edf92c9bf338a71a7e0c8 
>   interfaces/iplugin.h a8b112dc950a83c01bd987753a4d92beec8c981c 
>   interfaces/iplugin.cpp 5d14247ea87f61963e5e0875d8a908f6afd86200 
>   interfaces/iplugincontroller.cpp b772973967539d61ec2cdc0f5380618cf912333b 
>   interfaces/iprojectcontroller.h 189e820b1748a58e77d761a73adcbbd3d54cc47f 
>   interfaces/tests/CMakeLists.txt PRE-CREATION 
>   interfaces/tests/test_foregroundlock.h PRE-CREATION 
>   interfaces/tests/test_foregroundlock.cpp PRE-CREATION 
>   language/CMakeLists.txt b66418d4d9a479506a5df3a1d1606e44ef906273 
>   language/backgroundparser/backgroundparser.h 070ca5607b98bc9205fc750c4465d13feb1ca00d 
>   language/backgroundparser/backgroundparser.cpp 74a6ea8fb9cff7dfacd5692f2fd2f389e2e56bc0 
>   language/backgroundparser/parsejob.h 1c6131b40952de285b7f529bdb93a381ec18f591 
>   language/backgroundparser/parsejob.cpp a95127855d6602d9c9b8bfa6efbba2e14b326964 
>   language/codecompletion/codecompletionmodel.cpp 49a6a988232fdbfdfae901d91b5a50a39486345e 
>   language/codegen/createclass.cpp 7685e03cabfb7cd8c2c795d2f189ca6adcfd56a6 
>   language/codegen/documentchangeset.h e75a266392d824b0c785dfccd2939fc6c6da111d 
>   language/codegen/licenses/Apache fbf1e167c33ec9bc0e003881ed2500947a293cfe 
>   language/codegen/licenses/GPL 17dbc21c1897d0bfd356e19d35f288c12776e4ca 
>   language/codegen/licenses/GPL 77f941025e1e343e40176c752b7607bb72faf8c3 
>   language/codegen/licenses/LGPL 0b542d1975340da62aca48a3d9d239fe1f0b5483 
>   language/codegen/licenses/MIT 03cadb03deb15b2837fdce756ea1f16408f9e391 
>   language/duchain/declaration.cpp 75b438ebd974ec235edf8f9234e83eeee6102588 
>   language/duchain/declarationdata.h 0fda5c39a5353d9d76f95e881dd88815e381ec4e 
>   language/duchain/duchain.h a058c343e0697630c0f146c5a3c91ab104c249cc 
>   language/duchain/duchain.cpp d67ec67594146a6bf015c6c6803e2d1980ae03a0 
>   language/duchain/identifier.cpp 62530eb16c48a4ad68ddf0b19d7f43664f617a1d 
>   language/duchain/indexedstring.h 57285c8525038d4ce845cce3f1af4bea616c0978 
>   language/duchain/instantiationinformation.cpp 09fd71f0be6e6d50acc8fc39adf20ac5cdc9d934 
>   language/duchain/navigation/problemnavigationcontext.cpp b239f8338ee34629c583c1f3e7b417d4fbd65004 
>   language/duchain/referencecounting.cpp c631183a90e936badf36216aa1ebc697dd31d8ae 
>   language/duchain/repositories/typerepository.cpp 32a7bf78fb87fedd8c13c23e6a6874038d6e8703 
>   language/duchain/types/typeregister.h 4fad9def5d3762956f6909937b762c3b50d050fa 
>   language/duchain/types/typeregister.cpp 5caa548b7933382156eb7d34874a754258e22c37 
>   language/editor/modificationrevisionset.cpp 306d785fe5cc32fb529ebcf8c8f127317425b2a1 
>   language/highlighting/codehighlighting.h efcd035ba2a0dae66a04ec33f8033db854abd639 
>   language/highlighting/codehighlighting.cpp c9e9e1997191ec768cc34285b3f4e05b5a126dec 
>   language/util/navigationtooltip.h 861fc2902f34e060e68a2d0e70d66fcc434841a6 
>   outputview/CMakeLists.txt 8bc26509104a756d797679c7c2fbf3ad1c93df72 
>   plugins/contextbrowser/browsemanager.h 566a9e3f90d75666156c6c56c0539a3b39fef95a 
>   plugins/contextbrowser/browsemanager.cpp 65a673c8b32a889bb7c1b12949accb04d67205ff 
>   plugins/contextbrowser/contextbrowser.h aca213ff1b18151d7f8dbac62b9d3ade1e60f945 
>   plugins/contextbrowser/contextbrowser.cpp dcfa29cda4c11f8ff26e1e143de40bd02df322d1 
>   plugins/contextbrowser/contextbrowserview.h bf9a6d9d9d8a070f6de7b8e5d1cfa87ba9620f11 
>   plugins/contextbrowser/contextbrowserview.cpp 0c0438435ea91b57451817f6b2f7e1c87417c855 
>   plugins/documentswitcher/documentswitcherplugin.cpp 8659881d0b32646e881bd6e28829740ca62f2234 
>   plugins/documentview/kdevdocumentview.desktop 511d37a19611ac431a88191342e1c85ce549f5cb 
>   plugins/documentview/settings/kcm_documentview_settings.desktop 7258e85139b197691f4c20e4e0e32bc477fb2697 
>   plugins/execute/CMakeLists.txt 0454f7e9ef5be0dd63d39db52a4adf96bab46de6 
>   plugins/execute/nativeappjob.cpp 4c8921eabc4768487494f07443f36239ab6e1ddc 
>   plugins/git/gitplugin.h de40d50395af0d5c214ec0280bb1821ffdd46734 
>   plugins/git/gitplugin.cpp 449d2a59f5779934aa18a4abaad484601a4cbc1c 
>   plugins/git/kdevgit.desktop c3c0208ebf6274a63b27e4310f29f772a01db11b 
>   plugins/grepview/CMakeLists.txt 6c9602f14c08cff45e91f5bfd34a671b0d442af1 
>   plugins/grepview/grepdialog.h 3fde7a8cb6938a5cb485c56d30ce32434a35d0c6 
>   plugins/grepview/grepdialog.cpp f258825e7c79f701ce902fb12eab5d51f871462f 
>   plugins/grepview/grepjob.h e45f514568864f8eabfabdb6956b8a3b58097ad1 
>   plugins/grepview/grepjob.cpp 2feb18f3b45ec7b0f9a95641bba4e450b26e742c 
>   plugins/grepview/grepoutputdelegate.h c8a8db91666c186e46ce5fdef56bb50cc87e906e 
>   plugins/grepview/grepoutputdelegate.cpp e3d4c3cde3b3a5d4b6fb8471f3aeff7b2b18d4ef 
>   plugins/grepview/grepoutputmodel.h 065cc157adb518db36a494bc63168f2a448b4603 
>   plugins/grepview/grepoutputmodel.cpp fd4f2aa39673e9032be52b1e01ee44eb08c0abea 
>   plugins/grepview/grepoutputview.h 14cdd68a7056f7ea4ea23ce5e89739c5e56a8dfd 
>   plugins/grepview/grepoutputview.cpp e02e255aee5038e84cba48e3b9c5cb8b07e29605 
>   plugins/grepview/grepoutputview.ui 0b5ba94c60cb123f3650a51452f3c4de3ec47680 
>   plugins/grepview/greputil.h PRE-CREATION 
>   plugins/grepview/greputil.cpp PRE-CREATION 
>   plugins/grepview/grepwidget.ui ff8ea63ab9bf0a7a9efe2ded431257fb0793f850 
>   plugins/grepview/kdevgrepview.desktop 8b918d77cc3949a029a8c37f9da7047ad6f146bb 
>   plugins/grepview/tests/CMakeLists.txt 42b519288fab5b8d2e0e2d3ed2ecbe8e874ad4da 
>   plugins/grepview/tests/findreplacetest.cpp 0547030fceb63d74896c03d201760ef7225d2284 
>   plugins/openwith/CMakeLists.txt d735fbbde163f62e135f117020b4256f98b7c406 
>   plugins/problemreporter/problemreporterplugin.cpp 0825484e678b71c00521d0bcbd4ce92a6079ce37 
>   plugins/problemreporter/problemwidget.cpp 79634af88a1bbe5c9e94cb7051836cd2777d0315 
>   plugins/standardoutputview/kdevstandardoutputview.desktop 5d6bf2d1061743dd63d434317d2038d269f38e45 
>   project/CMakeLists.txt 1cf4d7cf0999999d8888ebb04dcd684160bb3358 
>   project/projectmodel.h 4ae32fbef674f85f75f6807659ca2ac15edf3754 
>   project/projectmodel.cpp 1bc51892c79a7bd90ad8f123ed319300d3f55b6c 
>   project/tests/projectmodelperformancetest.h d4e09db10da3bef0b3120df4745b099f05e85306 
>   project/tests/projectmodelperformancetest.cpp 6b20d07fbad9576c2f9c38799bd928d99719526b 
>   project/tests/projectmodeltest.h bb7268aacbd22a23efea22d2621948a1c785b873 
>   project/tests/projectmodeltest.cpp 1eb9e23736a119a20cc0dd2599692763c31af354 
>   shell/CMakeLists.txt 9d8cb599b2198d92f8b7a0c8ed2fea53cbd344e1 
>   shell/core.cpp 50cbab4d85e154e012b98419001e243bd87bfe14 
>   shell/documentcontroller.h 55b5653d7bc23688f566fd8068bf2bec8e51f569 
>   shell/documentcontroller.cpp c212b76b99c8ac666d569ff700f401081a80d08a 
>   shell/kross/examples/bzrkdevelop/kdevbzr.desktop 4cbcbfbc3ad696a375d7ff264869379368a17b0c 
>   shell/plugincontroller.cpp 15f5c553cc6b5adce6403c726e03fb36957474ba 
>   shell/projectcontroller.h 473b7cda28dad8d4da713c9205312a548c6fd736 
>   shell/projectcontroller.cpp 21b55dc5c646d8727c45bbe03aa8033f65736265 
>   shell/runcontroller.cpp 213f724afefe2d2a05be6cf3e9e5383713c7c19e 
>   shell/sessioncontroller.cpp 0aaf0175b6b5c0b980a5e850a9324e3f152c350a 
>   shell/settings/environmentwidget.cpp 5720caeb209fe96134ee7d6bb9632888228ff531 
>   shell/settings/environmentwidget.ui d7d4650f55a1994b36ea89097ae593a23c97990e 
>   shell/settings/kcm_kdev_projectsettings.desktop d3a9d433e2a82817a3045fbadf6d5efb033ff6f1 
>   shell/settings/pluginpreferences.cpp edb42903ecb1cd933b54357a46e633c763727197 
>   shell/workingsets/workingsettoolbutton.cpp b729213971d4b4d3f85781330345d8dcdf6c6f61 
>   sublime/CMakeLists.txt a4c3523ad0b963e7d776e0d73a9a95c12629340c 
>   sublime/container.cpp 4fa32d73c424763d216c14198556ace1aa298a49 
>   sublime/mainwindow_p.cpp a966e583cf7eed153970e209acf3a602193bbeb3 
>   tests/CMakeLists.txt f90cc070b4b9821ecec32e679810a65403c8e3f5 
>   util/CMakeLists.txt de8616d72c0acc2d4993f2b7b8a5921cc19083b0 
>   vcs/CMakeLists.txt 7419986e85ce3b3839532e814d231e242dc1bff1 
>   vcs/dvcs/dvcsjob.cpp cef340969a7405ed353ee59af5307ba9c5d0377b 
>   vcs/dvcs/ui/branchmanager.cpp 3ca8f5659f70a204d5cb3a4ad6894493e3d5e690 
> 
> Diff: http://git.reviewboard.kde.org/r/100216/diff
> 
> 
> Testing
> -------
> 
> Manually tested enabling/disabling git plugin while git was removed and then installed back.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101217/d30a58c7/attachment.html>

More information about the KDevelop-devel mailing list