Review Request: Show error messages when CMakeCache.txt cannot be written to.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100204/#review501
-----------------------------------------------------------

Ship it!


looks good with me, ship it.

- Milian


On 2010-12-10 22:28:14, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100204/
> -----------------------------------------------------------
> 
> (Updated 2010-12-10 22:28:14)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Show an error message when CMake cache data cannot be written on disk.
> This may happen after 'sudo make install' creates a root-owned CMakeCache.txt or something like that.
> Do not run 'configure' if writing failed.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakecachemodel.h 75dcb89e287ded582dbb0966d520f1e6c5245401 
>   projectmanagers/cmake/settings/cmakecachemodel.cpp 2478623a15c98d22afdcfd8799ff40f9399e3f80 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 06db6f7b30bf13b9af7ab8fb7cc1502a9a582f94 
> 
> Diff: http://git.reviewboard.kde.org/r/100204/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101212/84f74e16/attachment.html>