Patch - don't set environment in DvcsJob to parent process' environment in start function

[Morten Volden]

Okay - Thanks :-)

2010/12/9 Aleix Pol <aleixpol at kde.org>

> sorry I've misread the patch. Feel free to apply your patch :)
>
> Aleix
>
>
> On Thu, Dec 9, 2010 at 10:29 PM, Aleix Pol <aleixpol at kde.org> wrote:
>
>> On Thu, Dec 9, 2010 at 9:56 PM, Morten Volden <mvolden2 at gmail.com> wrote:
>>
>>> Hi All
>>>
>>> I currently use DvcsJob from kdevplatform when invoking commands in the
>>> perforce plugin (http://gitorious.org/perforce-plugin). The perforce
>>> client executable will read it's current working directory from the
>>> environment variable PWD. This variable is apperently is not what is set
>>> when calling QProcess::setWorkingDirectory in the DvcsJob constructor.
>>>
>>> In DVcsJob::start function there is a call to QProcess::setEnvironment
>>> which sets the environment to that of the parent process (I am told that
>>> this is redundant since Kjob already sets it). My patch simply removes this
>>> line so that a client using DvcsJob can now set the environment of the job.
>>>
>>> Regards
>>>
>>> Morten
>>>
>>> --
>>>
>>> KDevelop-devel mailing list
>>> KDevelop-devel at kdevelop.org
>>> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>>>
>>>
>> The working directroy should be specified by the constructor's first
>> parameter, why do you need to pass such static  ::systemSettings()
>> information?
>>
>>
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101209/b9d75b26/attachment.html>