Review Request: Fix no-op on clicking <cmake target>->Execute As in Projects view.

Nicolas Alvarez nicolas.alvarez at gmail.com
Wed Dec 1 06:56:38 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100180/#review448
-----------------------------------------------------------

Ship it!


Well spotted!

I can't think of any legitimate use of connect() in kDebug or Q_ASSERT, so maybe this should be detected by krazy... 

- Nicolas


On 2010-11-30 21:54:54, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100180/
> -----------------------------------------------------------
> 
> (Updated 2010-11-30 21:54:54)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Move signal/slot connection out of kDebug - otherwise it may not be called in Release mode.
> 
> 
> Diffs
> -----
> 
>   shell/runcontroller.cpp 213f724afefe2d2a05be6cf3e9e5383713c7c19e 
> 
> Diff: http://git.reviewboard.kde.org/r/100180/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101201/d938d7d7/attachment.html>


More information about the KDevelop-devel mailing list