Request for review: Grepview plugin rewrite

[Andreas Pakulat]

On 27.08.10 15:39:36, Syron wrote:
> OK, changed the PCRE matching from ascii to utf-8 and also removed the

That only works if pcre has been built with utf8 support as far as I
could see. What happens if its built without utf8 support? IMHO we
should use QRegExp unless you can prove in that plugin that searching
with QRegExp is much slower than PCRE on a codebase like kdevplatform.
With not too-simple regexps. Also note that conversion between some
char* and QString (in particular when also converting encoding) is also
costly..

Andreas

-- 
Tomorrow will be cancelled due to lack of interest.