Request for review: Grepview plugin rewrite

[Andreas Pakulat]

On 27.08.10 14:29:32, Aleix Pol wrote:
> Well, before having tried it I have been browsing through the code for a
> while and I have few comments.
> 
> - Please explain a little the background, why do you use PCRE instead of
> QRegExp? it adds a dependency and I'm not sure if it's such a big advantage
> (I don't know, but there has to be a reason).

In particular as that means having to jump through hoops to make stuff work
correctly with non-ascii strings.

> - Don't use singleShot for delaying slot processing, it's preferred to use
> QMetaObject::invokeMethod with Qt::QueuedConnection type

Who said that? singleShot is just fine for doing delayed slot processing if
everything runs in the main thread.

Andreas

-- 
Your analyst has you mixed up with another patient.  Don't believe a
thing he tells you.