Review Request: Display of many function overloads in code completion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3612/#review5065
-----------------------------------------------------------


generally a really good idea, I'd like to see it working as you said:

show up to X elements, if there are more show "... and X more overloads of FOO"

but your patch is not working and the additional parameter is imo unnecessary.

Note: since this requires string changes, it will probably get merged after 4.0.0 release, actually not so bad idea to get it tested properly.
Please make the string as useful as possible. (see above).


trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.h
<http://reviewboard.kde.org/r/3612/#comment4546>

    what's the difference between fullCompletion and automaticInvocation?
    
    imo you want to check against fullCompletion, no need for the additional parameter



trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.cpp
<http://reviewboard.kde.org/r/3612/#comment4544>

    this is not filtering properly, I now get like 20 function hints in e.g.:
    
    QString s;
    s.append(|);
    
    place the cursor at the pipe.



trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.cpp
<http://reviewboard.kde.org/r/3612/#comment4545>

    you are in a loop that checks the functions, so this will always be true, remove it


- Milian


On 2010-04-15 14:29:12, Thomas Schöps wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3612/
> -----------------------------------------------------------
> 
> (Updated 2010-04-15 14:29:12)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> I tried to fix this:
> https://bugs.kde.org/show_bug.cgi?id=215206
> 
> With the patch, Ctrl+Space always shows all overloads, while automatic invocation of code completion shows the first 5 overloads and possibly "x more overloads of y".
> Currently, the automatic invocation case doesn't happen because automatic code completion after '(' is disabled.
> It would be even better if the "more overloads" item would be clickable to reveal the remaining items, but I don't know how to implement this and as it isn't shown currently, it's probably not too important.
> 
> I've never coded on KDevelop/KDevplatform or even a KDE app before, so please check the patch carefully and tell me if that is not the correct way to implement it ;-)
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.h 1115078 
>   trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/context.cpp 1115078 
>   trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletioncontext.h 1115078 
>   trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionmodel.cpp 1115078 
>   trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionworker.h 1115078 
>   trunk/extragear/sdk/kdevplatform/language/codecompletion/codecompletionworker.cpp 1115078 
> 
> Diff: http://reviewboard.kde.org/r/3612/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>