Review Request: Use different macro replacements for SIGNAL and SLOT

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3570/#review4986
-----------------------------------------------------------


please remove the unrelated whitespace changes.

otherwise looks good to me, I'd say ship it after 4.0.0 release or now if David is OK with it.

@apaku: this is useful for any tool that reuses the cpp parser, like e.g. Tobias' signal/slot connection checker.
of course, it's not required in an editor, but imo it's good if we get more tools using the cpp lang plugin as a backend, since it will result in more coverage, usage, testing, ...


/trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.cpp
<http://reviewboard.kde.org/r/3570/#comment4455>

    dunno, maybe this should be merged with the stuff below? only the CHECK() differs, no?


- Milian


On 2010-04-12 10:39:31, Tobias Koenig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3570/
> -----------------------------------------------------------
> 
> (Updated 2010-04-12 10:39:31)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch replaces the internal __qt_sig_slot__ macro with the two macros __qt_signal__ and __qt_slot__, this allows to check whether the SIGNAL or SLOT macro has been used in the original source code.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/tests/test_duchain.cpp 1113929 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/lexer.cpp 1113929 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.cpp 1113929 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.h 1113929 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.cpp 1113929 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/setuphelpers.cpp 1113929 
> 
> Diff: http://reviewboard.kde.org/r/3570/diff
> 
> 
> Testing
> -------
> 
> Run unit tests without signal/slot related errors
> 
> 
> Thanks,
> 
> Tobias
> 
>