Review Request: Show definition as default action in classbrowser

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3564/#review4982
-----------------------------------------------------------



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.h
<http://reviewboard.kde.org/r/3564/#comment4444>

    no need to change the names here



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4446>

    no unrelated whitespace changes please



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4445>

    as above, no need for name changes



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4447>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4448>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4449>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4450>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4451>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp
<http://reviewboard.kde.org/r/3564/#comment4452>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classtree.cpp
<http://reviewboard.kde.org/r/3564/#comment4453>

    same as above



/trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classtree.cpp
<http://reviewboard.kde.org/r/3564/#comment4454>

    same as above


- Milian


On 2010-04-11 13:05:15, André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3564/
> -----------------------------------------------------------
> 
> (Updated 2010-04-11 13:05:15)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch is a fix/addition for Bug 223124 that I filed myself. Instead of jumping to a function's declaration when selecting an item in class browser, the function's definition is shown. I think this is much more intuitive behavior and is also implemented in most other IDEs.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.h 1113664 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classbrowserplugin.cpp 1113664 
>   /trunk/extragear/sdk/kdevplatform/plugins/classbrowser/classtree.cpp 1113664 
> 
> Diff: http://reviewboard.kde.org/r/3564/diff
> 
> 
> Testing
> -------
> 
> Tested with three different projects without problems/crashs/deadlocks.
> 
> 
> Thanks,
> 
> André
> 
>