Review Request: Use different macro replacements for SIGNAL and SLOT

Tobias Koenig tokoe at kde.org
Mon Apr 12 10:39:31 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3570/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

This patch replaces the internal __qt_sig_slot__ macro with the two macros __qt_signal__ and __qt_slot__, this allows to check whether the SIGNAL or SLOT macro has been used in the original source code.


Diffs
-----

  /trunk/extragear/sdk/kdevelop/languages/cpp/cppduchain/tests/test_duchain.cpp 1113929 
  /trunk/extragear/sdk/kdevelop/languages/cpp/parser/lexer.cpp 1113929 
  /trunk/extragear/sdk/kdevelop/languages/cpp/parser/parser.cpp 1113929 
  /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.h 1113929 
  /trunk/extragear/sdk/kdevelop/languages/cpp/parser/tokens.cpp 1113929 
  /trunk/extragear/sdk/kdevelop/languages/cpp/setuphelpers.cpp 1113929 

Diff: http://reviewboard.kde.org/r/3570/diff


Testing
-------

Run unit tests without signal/slot related errors


Thanks,

Tobias





More information about the KDevelop-devel mailing list