Review Request: Don't abort completion when entering "~" for destructors

Milian Wolff mail at milianw.de
Sat Apr 10 16:00:42 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3541/#review4953
-----------------------------------------------------------

Ship it!


look fine, please commit after fixing the comment


trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/model.cpp
<http://reviewboard.kde.org/r/3541/#comment4399>

    comment grammar is not clear :)


- Milian


On 2010-04-10 08:26:45, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3541/
> -----------------------------------------------------------
> 
> (Updated 2010-04-10 08:26:45)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This fixes typing the first characters of completion item "override <destructor> ~Foo"
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/model.h 1112563 
>   trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/model.cpp 1112563 
> 
> Diff: http://reviewboard.kde.org/r/3541/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko
> 
>





More information about the KDevelop-devel mailing list