Review Request: Add mapping of Uses to AST nodes.

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1710/#review2481
-----------------------------------------------------------

Ship it!


Apart from the assertion, it's good.


trunk/KDE/kdevelop/languages/cpp/parser/parsesession.cpp
<http://reviewboard.kde.org/r/1710/#comment1819>

    This assertion should be turned into a warning. The problem: C++ is so complex that you can never be sure that we process all of the code that is out there correctly, and problems in the code-understanding should not lead to crashes.


- David


On 2009-09-28 12:02:28, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1710/
> -----------------------------------------------------------
> 
> (Updated 2009-09-28 12:02:28)
> 
> 
> Review request for KDevelop, Andreas Pakulat, Milian Wolff, and David Nolden.
> 
> 
> Summary
> -------
> 
> Adds a mapping of uses and AST nodes to ParseSession in addition to mappings between DUCHain declarations and nodes. I also factored out some code related to mappings out of DeclarationBuilder into ContextBuilder.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.h 1027714 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.cpp 1027714 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.h 1027714 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp 1027714 
>   trunk/KDE/kdevelop/languages/cpp/cppduchain/usebuilder.cpp 1027714 
>   trunk/KDE/kdevelop/languages/cpp/cppparsejob.cpp 1027714 
>   trunk/KDE/kdevelop/languages/cpp/parser/parsesession.h 1027714 
>   trunk/KDE/kdevelop/languages/cpp/parser/parsesession.cpp 1027714 
>   trunk/KDE/kdevplatform/language/duchain/builders/abstractusebuilder.h 1027953 
> 
> Diff: http://reviewboard.kde.org/r/1710/diff
> 
> 
> Testing
> -------
> 
> Work with a KDevelop that has this patch applied. No crashes related to this seem to happen. I did not yet test which nodes actually get mapped. Will do that soon.
> 
> 
> Thanks,
> 
> Bertjan
> 
>