Review Request: Add mapping of Uses to AST nodes.

Bertjan Broeksema b.broeksema at home.nl
Fri Sep 25 13:50:51 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1710/
-----------------------------------------------------------

(Updated 2009-09-25 13:50:50.930063)


Review request for KDevelop, Andreas Pakulat, Milian Wolff, and David Nolden.


Changes
-------

I've made the suggested changes. Also I put in the complete diff now (there are also changes in kdevplatform). Furthermore I ran the tests and those run still fine except for kdevelop/languages/cpp/tests/cppcodegentest

But that one doesn't work for me without the patch either.


Summary
-------

Adds a mapping of uses and AST nodes to ParseSession in addition to mappings between DUCHain declarations and nodes. I also factored out some code related to mappings out of DeclarationBuilder into ContextBuilder.


Diffs (updated)
-----

  trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.h 1027714 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/contextbuilder.cpp 1027714 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.h 1027714 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/declarationbuilder.cpp 1027714 
  trunk/KDE/kdevelop/languages/cpp/cppduchain/usebuilder.cpp 1027714 
  trunk/KDE/kdevelop/languages/cpp/parser/parsesession.h 1027714 
  trunk/KDE/kdevelop/languages/cpp/parser/parsesession.cpp 1027714 
  trunk/KDE/kdevplatform/language/duchain/builders/abstractusebuilder.h 1027953 

Diff: http://reviewboard.kde.org/r/1710/diff


Testing
-------

Work with a KDevelop that has this patch applied. No crashes related to this seem to happen. I did not yet test which nodes actually get mapped. Will do that soon.


Thanks,

Bertjan





More information about the KDevelop-devel mailing list