Review Request: render_position.cpp:94: warning: comparison between signed and unsigned integer expressions

Guy Maurel guy-kde at maurel.de
Fri Oct 16 17:44:25 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1864/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

The dashboard
  http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
reports:
khtml/rendering/render_position.cpp:94: warning: comparison between signed and unsigned integer expressions
khtml/rendering/render_position.cpp:98: warning: comparison between signed and unsigned integer expressions

at
InlineBox* RenderPosition::getInlineBoxAndOffset(int& offset) const

I propose to change the declaration of "renderOffset" to
"unsigned int"
see: render_position-gm-13.diff


Diffs
-----

  /trunk/KDE/kdelibs/khtml/rendering/render_position.cpp 1033934 

Diff: http://reviewboard.kde.org/r/1864/diff


Testing
-------


Thanks,

Guy





More information about the KDevelop-devel mailing list