Review request: control flow graph plugin

[Andreas Pakulat]

On 06.10.09 15:36:58, Sandro Andrade wrote:
> On Tue, Oct 6, 2009 at 4:14 AM, Andreas Pakulat <apaku at gmx.de> wrote:
> 
> > On 05.10.09 19:14:02, Sandro Andrade wrote:
> > > Hi guys,
> > >
> > > Any suggestions for the control flow graph plugin ?
> >
> > TBH: I didn't spend any time on kdevelop in the last 2 weeks.
> > Additionally I still can't compile the plugin because kgraphviewer
> > doesn't build against libgraphviz 2.20 (it apparently needs 2.22). I've
> > asked the author already, but seems he didn't have time yet to look into
> > it.
> >
> 
> Hi Andreas, I'll check this by myself.

I've meanwhile built libgraphviz myself (2.24) so I could also build
kgraphviewer and the controlflow plugin. Unfortunately it seems to be
crashing during creation of the graph. I'm adding the toolview, opening
it up and then setting the cursor into a source file and "bang". The
last output is:
QObject::connect: Cannot connect DotGraphView::removeEdge(const
QString&) to (null)::removeEdge(const QString&)                         
QObject::connect: Cannot connect DotGraphView::removeNodeNamed(const
QString&) to (null)::removeNodeNamed(const QString&)               
QObject::connect: Cannot connect DotGraphView::removeElement(const
QString&) to (null)::removeElement(const QString&)        

Backtrace:
#0  agsubg (g=0x0, name=0xd076ee0 "cluster_Global Namespace") at
graph.c:306
#1  0xeb027dd8 in DotControlFlowGraph::foundRootNode (this=0xc752be0,
containers=QList = {...}, label="ControlFlo")
    at /home/andreas/src/controlflowgraph/dotcontrolflowgraph.cpp:81
#2  0xeb016964 in DotControlFlowGraph::qt_metacall (this=0xc752be0,
_c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x10260ad8)
    at
/home/andreas/src/controlflowgraph/build/moc_dotcontrolflowgraph.cpp:89
#3  0xf696f88b in QMetaObject::metacall (object=0xc752be0,
cl=QMetaObject::InvokeMetaMethod, idx=6, argv=0x10260ad8)
    at /home/andreas/src/kde-qt/src/corelib/kernel/qmetaobject.cpp:237
#4  0xf697ce29 in QMetaCallEvent::placeMetaCall (this=0xeebdc30,
object=0xc752be0)
    at /home/andreas/src/kde-qt/src/corelib/kernel/qobject.cpp:562

In the above case I first set the cursor to a line and then opened the
toolview, which lead to this.

I'll be just reviewing the source code for now :)

Andreas

-- 
Don't plan any hasty moves.  You'll be evicted soon anyway.