KDE/kdevplatform/debugger/variable

[Vladimir Prus]

On Wednesday 14 October 2009 Niko Sams wrote:

> On Tue, Oct 13, 2009 at 22:18, Vladimir Prus <ghost at cs.msu.su> wrote:
> > On Saturday 03 October 2009 Niko Sams wrote:
> >
> >> SVN commit 1030728 by nsams:
> >>
> >> Don't crash when debugger doesn't provide a VariableController
> >>
> >>  M  +6 -0      variablecollection.cpp
> >>
> >>
> >> --- trunk/KDE/kdevplatform/debugger/variable/variablecollection.cpp #1030727:1030728
> >> @@ -138,6 +138,7 @@
> >>
> >>  Variable* Watches::add(const QString& expression)
> >>  {
> >> +    if (!currentSession()->variableController()) return 0;
> >
> >
> > It seems to me that if methods of Watches class is called when there's
> > no variable controller, then things are very, very broken. Am I missing
> > something?
> If a debugger plugin doesn't have a VariableController (because it's
> simply not implemented)
> then this could happen.
> This *was* the case for xdebug.

Ah, I see.

> If you think we don't need to support this I can revert it.

I think it's best to undo this change indeed -- so that code is not
complicated by the logic handling case that should never be the
case. Is there any place convenient where we can assert that
variable controller is not null, after debug session is constructed?

- Volodya

> 
> Niko
>