KDE/kdevplatform/debugger/variable

[Niko Sams]

On Tue, Oct 13, 2009 at 22:27, Vladimir Prus <ghost at cs.msu.su> wrote:
> On Sunday 11 October 2009 Niko Sams wrote:
>
>> SVN commit 1033903 by nsams:
>>
>> Make methods public to modify children from outside.
>> (Needed in xdebug plugin)
>>
>>  M  +5 -1      variablecollection.h
>>
>>
>> --- trunk/KDE/kdevplatform/debugger/variable/variablecollection.h #1033902:1033903
>> @@ -140,8 +140,12 @@
>>      Locals(TreeModel* model, TreeItem* parent);
>>      void updateLocals(QStringList locals);
>>
>> +    using TreeItem::setHasMore;
>> +    using TreeItem::child;
>> +    using TreeItem::childCount;
>> +    using TreeItem::appendChild;
>> +    using TreeItem::removeChild;
>>      using TreeItem::deleteChildren;
>> -    using TreeItem::setHasMore;
>
> Why is this actually needed? Why can't xdebug plugin derive from the Variable class?
I added this to Locals only.
Because I can't use updateLocals - as I get more information from the
debugger (like
values and children) for the locals.
Another option would be to make updateLocals more flexible.

What's so bad about making it public?
Imho making those methods public in TreeItem would make things easier. Is there
any disadvantage?

Niko