Patch to make cmakeManager return clean path

David Nolden zwabel at googlemail.com
Sun Nov 15 16:31:05 UTC 2009


Am Sonntag 15 November 2009 16:33:17 schrieb Benjamin Schindler:
> Hi
> 
> Quite often one gets include path from cmake such as:
> /some/build/dir//someincludeDir
> 
> Even though such a path is valid, some comparisons fails (such as the
> one in includepathcomputer.cpp:208:
> 
>      m_hasPath.contains(r)
> 
> The attached patch fixes this problem. However, I'm not sure whether
> this is the correct solution. The m_hasPath.contains(r) should succeed imho
> 
> Cheers
> Benjamin
> 

The patch does not look good, it attaches the same path twice, which is messy. 
Also one has to consider that retrieving include paths is already quite slow 
in cmake, ideally the appropriate processing would be done only once while 
parsing, and not whenever the include-paths are requested (unless of course 
it's done that way in this patch, I haven't checked the context).

Greetings, David




More information about the KDevelop-devel mailing list