Patch for includepathresolver.cpp

[David Nolden]

Am Mittwoch 27 Mai 2009 20:11:58 schrieb Christoph Bartoschek:
> Sorry for the first incomplete mail.
>
> Am Mittwoch, 27. Mai 2009 schrieb David Nolden:
> > I also see a remaining issue with this code that might make it randomly
> > fail. It is used from multiple background threads at the same time, and
> > the QDir::setCurrentDirectory isn't needed any more and is probably
> > anyway the one basic problem. The working-directory should be applied by
> > using the QFileInfo(QDir dir, QString file) constructor, if one was
> > given.
>
> I've modified the patch and attached it here.
Committed, thanks.

> > Am Mittwoch 27 Mai 2009 18:22:20 schrieb Christoph Bartoschek:
> > > 1. How to handle the errors that occur during such operations. For
> > > example if one do not has the permission to modify the files. In my
> > > opinion a global section of the Problems Tab is the correct place. How
> > > to add it there? The user should not be bothered with such problems
> > > during his work but the problems should not be ignored. They should be
> > > part of a logfile or something similar. Is there a logging mechanism
> > > for kdevelop for optimized runs? I think that kDebug is not an option
> > > here.
> >
> > Are you sure this actually works correctly? The problem is, that this
> > isn't needed in all cases. The include-path resolver also gives a command
> > to "make" that tells it to internally mark the specific files at updated.
> > This just doesn't work when "make" redirects its call to other commands,
> > thus the touching.
>
> What do you mean here? I do not see how this is relevant to the reporting
> of problems.

The relevant part was behind that one. The important point is: I'm unsure 
whether that's really such an important issue that it needs to be shown in the 
UI. Probably a kWarning would do.

Greetings, David